[PATCH] D23766: DebugInfo: use strongly typed enum for debug info flags

[Victor via llvm-commits]

vleschuk removed rL LLVM as the repository for this revision.
vleschuk updated this revision to Diff 70367.
vleschuk added a comment.

Got rid of the following warning:

> warning: default label in switch which covers all enumeration values [-Wcovered-switch-default]


in getFlagString() function. Removed "default" from switch/case, put " return ""; " outside switch construction.

The default case is required in this function in case someone puts a combination of Flags (or garbage) into it. These cases are covered in

unittests/IR/DebugInfoTest.cpp - they were the tests that failed after @mehdi_amini committed changes. Now the patch should be good to go and code builds without warnings.


https://reviews.llvm.org/D23766

Files:
  include/llvm/IR/DIBuilder.h
  include/llvm/IR/DebugInfoFlags.def
  include/llvm/IR/DebugInfoMetadata.h
  lib/AsmParser/LLParser.cpp
  lib/Bitcode/Reader/BitcodeReader.cpp
  lib/IR/AsmWriter.cpp
  lib/IR/DIBuilder.cpp
  lib/IR/DebugInfoMetadata.cpp
  unittests/IR/DebugInfoTest.cpp
  unittests/IR/DebugTypeODRUniquingTest.cpp
  unittests/IR/IRBuilderTest.cpp
  unittests/IR/MetadataTest.cpp
  unittests/Transforms/Utils/Cloning.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D23766.70367.patch
Type: text/x-patch
Size: 76369 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160906/6a7464eb/attachment.bin>