[llvm] r280547 - [Profile] handle select instruction in 'expect' lowering

Sanjay Patel via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 5 16:30:08 PDT 2016


Hi Renato -

The likelihood that this change would fail on one bot but not others seems
really small. Now that I think about it, so would the commit that I
reverted at:
 rL280676 <https://reviews.llvm.org/rL280676>

If the bot is using stale binaries for the tools under test but running
'check' with updated regression tests, then it will appear that *every*
commit since the binary became stale is causing a failure, right?


On Mon, Sep 5, 2016 at 4:13 PM, Renato Golin via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> On 2 September 2016 at 23:03, Xinliang David Li via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
> > Author: davidxl
> > Date: Fri Sep  2 17:03:40 2016
> > New Revision: 280547
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=280547&view=rev
> > Log:
> > [Profile] handle select instruction in 'expect' lowering
> >
> > Builtin expect lowering currently ignores select. This patch
> > fixes the issue
>
> Hi Xinliang,
>
> This one looks like it's yours:
>
> http://lab.llvm.org:8011/builders/clang-cmake-armv7-
> a15/builds/14952/steps/ninja%20check%201/logs/FAIL%3A%20LLVM%3A%3Abasic.ll
>
> Unfortunately, our bots didn't detect because of a change in the
> builder which made all bots not report any errors.
>
> If you can't fix it quickly, please revert and we'll investigate that
> later, as right now, we're dealing with a large number of concurrent
> failures and we won't have time to investigate further.
>
> Sorry.
>
> --renato
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160905/ac13c598/attachment.html>


More information about the llvm-commits mailing list