[PATCH] D24093: [PPC] Claim stack frame before storing into it, if no red zone is present

[Hal Finkel via llvm-commits]

hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.

A few minor nits; otherwise, LGTM.


================
Comment at: lib/Target/PowerPC/PPCFrameLowering.cpp:907
@@ -909,1 +906,3 @@
+      !(SingleScratchReg && MustSaveLR)) { // will only occur for PPC64
+    assert(HasRedZone);
     BuildMI(MBB, MBBI, dl, TII.get(PPC::STW8))
----------------
Please add a message with this assert, e.g.

assert(HasRedZone && "A red zone is always available on PPC64");

================
Comment at: lib/Target/PowerPC/PPCFrameLowering.cpp:987
@@ +986,3 @@
+  if (!HasRedZone) {
+    assert(!isPPC64);
+    if (HasSTUX) {
----------------
Please add a message with this assert, e.g.

  assert(!isPPC64 && "A red zone is always available on PPC64");

================
Comment at: test/CodeGen/PowerPC/stack-realign.ll:142
@@ +141,3 @@
+; CHECK-32: stw 31, -4(0)
+; CHECK-32: stw 30, -8(0)
+; CHECK-32: mr 30, 0
----------------
This line and the one above it should be CHECK-32-DAG; their order is interchangeable.


Repository:
  rL LLVM

https://reviews.llvm.org/D24093