[PATCH] D24222: Add missing _US_ACTION_MASK constant to unwind.h

Dimitry Andric via llvm-commits llvm-commits at lists.llvm.org
Sun Sep 4 13:40:28 PDT 2016


dim created this revision.
dim added reviewers: emaste, logan, kledzik.
dim added a subscriber: llvm-commits.
Herald added subscribers: emaste, aemerson.

During building of recent compiler-rt sources on FreeBSD for arm, I
noticed that our unwind.h (which originates in libunwind) was missing
the `_US_ACTION_MASK` constant:

    compiler-rt/lib/builtins/gcc_personality_v0.c:187:18: error: use of undeclared identifier '_US_ACTION_MASK'
        if ((state & _US_ACTION_MASK) != _US_UNWIND_FRAME_STARTING)
                     ^

It appears that both clang's internal unwind.h, and libgcc's unwind.h
define this constant as 3, so let's add this to libunwind's version too.

https://reviews.llvm.org/D24222

Files:
  include/unwind.h

Index: include/unwind.h
===================================================================
--- include/unwind.h
+++ include/unwind.h
@@ -57,6 +57,7 @@
 static const _Unwind_State _US_VIRTUAL_UNWIND_FRAME   = 0;
 static const _Unwind_State _US_UNWIND_FRAME_STARTING  = 1;
 static const _Unwind_State _US_UNWIND_FRAME_RESUME    = 2;
+static const _Unwind_State _US_ACTION_MASK            = 3;
 /* Undocumented flag for force unwinding. */
 static const _Unwind_State _US_FORCE_UNWIND           = 8;
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D24222.70292.patch
Type: text/x-patch
Size: 500 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160904/caff2cfb/attachment.bin>


More information about the llvm-commits mailing list