[PATCH] D21562: [AMDGPU] Wave and register controls

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 2 18:09:55 PDT 2016


arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.

LGTM


================
Comment at: lib/Target/AMDGPU/SIRegisterInfo.cpp:871-872
@@ +870,4 @@
+unsigned SIRegisterInfo::getNumReservedSGPRs(const SISubtarget &ST) const {
+  if (ST.getGeneration() >= AMDGPUSubtarget::VOLCANIC_ISLANDS)
+    return 6; // VCC, FLAT_SCRATCH, XNACK.
+  return 2; // VCC.
----------------
This should be narrowed to just if the xnack feature is enabled


https://reviews.llvm.org/D21562





More information about the llvm-commits mailing list