[PATCH] D23931: [XRay] ARM 32-bit no-Thumb support in LLVM

[Serge Rogatch via llvm-commits]

rSerge marked 4 inline comments as done.
rSerge added a comment.

> Limit support for ARMv7A, non-Windows (which forces Thumb2). Something like:

> 

>   if (!SubTarget->hasV7Ops() || SubTarget->isWindows())

>     return Forgerabarit.

>    


It seems that ARMv6 is sufficient. Implemented mostly as suggested.


================
Comment at: lib/Target/ARM/ARMMCInstLower.cpp:159
@@ +158,3 @@
+
+void ARMAsmPrinter::EmitSled(const MachineInstr &MI, SledKind Kind)
+{
----------------
Changed.

================
Comment at: lib/Target/ARM/ARMMCInstLower.cpp:199
@@ +198,3 @@
+    OutStreamer->EmitInstruction(Noop, getSubtargetInfo());
+  }
+
----------------
Done.

================
Comment at: test/CodeGen/ARM/xray-attribute-instrumentation.ll:6
@@ +5,3 @@
+; CHECK-NEXT:  b	#20
+; CHECK-NEXT:  nop
+; CHECK-NEXT:  nop
----------------
Done.


https://reviews.llvm.org/D23931