[PATCH] D23829: [ELF] - Use std::regex instead of hand written logic in elf::globMatch()

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 2 13:29:13 PDT 2016


grimar added inline comments.

================
Comment at: test/ELF/wildcards2.s:18
@@ +17,3 @@
+# RUN:   %s -o %T/aaa.foo(+${}^bar).o
+# RUN: echo "SECTIONS { .text : { \"*aaa.foo(+${}^bar).o\"(.abc) } }" > %t2.script
+# RUN: ld.lld -o %t.out --script %t2.script %T/aaa.foo(+${}^bar).o
----------------
grimar wrote:
> ruiu wrote:
> > grimar wrote:
> > > It is not possible to create file with "|" "/" or "\" in name, so this is not tested here.
> > You don't need to test this this vigorously. It is too easy to break on minor filesystems. Add a test just for `.`.
> Done.
Posted this comment too early. Will be done in updated diff I mean.


https://reviews.llvm.org/D23829





More information about the llvm-commits mailing list