[PATCH] D24191: [Polly] Add check-polly-tests build target.

Michael Kruse via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 2 07:26:30 PDT 2016


Meinersbur created this revision.
Meinersbur added reviewers: grosser, jdoerfert, etherzhhb.
Meinersbur added subscribers: pollydev, llvm-commits.
Meinersbur added a project: Polly.

The check-polly-tests target runs regression/unit tests but without checking format. This is useful to not having to reload a file in an open editor (which eg. clears the undo buffer, moves cursor/window position) when running polly-update-format.

After this change, the following test targets exist:
 - check-polly-unittests to run unittests only
 - check-polly-tests to run unit and regression tests
 - polly-check-format to check formatting using clang-format
 - check-polly to run them all

As a side-effect, when running check-polly, polly-check-format and run in parallel (instead of polly-check-format first).

https://reviews.llvm.org/D24191

Files:
  test/CMakeLists.txt

Index: test/CMakeLists.txt
===================================================================
--- test/CMakeLists.txt
+++ test/CMakeLists.txt
@@ -12,6 +12,9 @@
 set(POLLY_BINARY_DIR "${CMAKE_CURRENT_BINARY_DIR}/..")
 set(LLVM_SHLIBEXT "${CMAKE_SHARED_MODULE_SUFFIX}")
 
+add_custom_target(check-polly)
+set_target_properties(check-polly PROPERTIES FOLDER "Polly")
+
 if (NOT DEFINED LLVM_MAIN_SRC_DIR)
 
   # We are building polly out of tree, adjust the settings.
@@ -67,16 +70,17 @@
       set_target_properties(polly-test-${testdir} PROPERTIES FOLDER "Polly")
     endforeach()
 
-    add_custom_target(check-polly
+    add_custom_target(check-polly-tests
       COMMAND ${LLVM_LIT}
                   --param polly_site_config=${CMAKE_CURRENT_BINARY_DIR}/lit.site.cfg
                   --param polly_unit_site_config=${CMAKE_CURRENT_BINARY_DIR}/Unit/lit.site.cfg
                   --param build_config=${CMAKE_CFG_INTDIR}
                   -sv ${POLLY_TEST_EXTRA_ARGS}
                   ${CMAKE_CURRENT_BINARY_DIR}
                   DEPENDS ${POLLY_TEST_DEPS}
                   COMMENT "Running Polly regression/unit tests")
-    set_target_properties(check-polly PROPERTIES FOLDER "Polly")
+    set_target_properties(check-polly-tests PROPERTIES FOLDER "Polly")
+    add_dependencies(check-polly check-polly-tests)
 
     if (POLLY_GTEST_AVAIL)
       configure_file(
@@ -113,14 +117,14 @@
     ${CMAKE_CURRENT_BINARY_DIR}/lit.site.cfg)
 
   # Run regression and unit tests
-  add_lit_testsuite(check-polly "Running polly regression tests"
+  add_lit_testsuite(check-polly-tests "Running polly regression tests"
     ${CMAKE_CURRENT_BINARY_DIR}
     PARAMS polly_site_config=${CMAKE_CURRENT_BINARY_DIR}/lit.site.cfg
            polly_unit_site_config=${CMAKE_CURRENT_BINARY_DIR}/Unit/lit.site.cfg
     DEPENDS ${POLLY_TEST_DEPS}
     )
-
-  set_target_properties(check-polly PROPERTIES FOLDER "Polly")
+  set_target_properties(check-polly-tests PROPERTIES FOLDER "Polly")
+  add_dependencies(check-polly check-polly-tests)
 
   if (POLLY_GTEST_AVAIL)
     configure_lit_site_cfg(


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D24191.70160.patch
Type: text/x-patch
Size: 2092 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160902/882be6d9/attachment.bin>


More information about the llvm-commits mailing list