[PATCH] D24160: llvm-objdump: Implement --start-address and --stop-address
Saleem Abdulrasool via llvm-commits
llvm-commits at lists.llvm.org
Thu Sep 1 22:53:19 PDT 2016
compnerd added a comment.
Thoughts on using obj2yaml/yaml2obj on the binary?
================
Comment at: test/tools/llvm-objdump/X86/start-stop-address.test:29
@@ +28,2 @@
+// CROSSDATA-NEXT: 45: 74 65 te
+
----------------
Alignment makes reading the output easier, and whitespace is ignored anyways.
================
Comment at: tools/llvm-objdump/llvm-objdump.cpp:1529
@@ -1494,1 +1528,3 @@
+ if ((SectionAddr + addr) < StartAddress)
+ goto skip_print_rel;
// Stop when rel_cur's address is past the current instruction.
----------------
Why use goto rather than wrap the bit in the if condition?
Repository:
rL LLVM
https://reviews.llvm.org/D24160
More information about the llvm-commits
mailing list