[PATCH] D23841: Fix ThinLTO crash with debug info

Teresa Johnson via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 1 19:44:04 PDT 2016


tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.

LGTM with a couple of test case fixes noted below.


================
Comment at: test/ThinLTO/X86/crash_debuginfo.ll:7
@@ +6,3 @@
+
+; Verify that we import bar and inline it. It use to crash importing due to ODR type uniquing
+; CHECK: foo
----------------
How are you verifying that bar is imported? Can you check for the inlined add in the body of foo?

================
Comment at: test/ThinLTO/X86/crash_debuginfo.ll:9
@@ +8,3 @@
+; CHECK: foo
+; CHECK-NOt: bar
+
----------------
s/NOt/NOT


https://reviews.llvm.org/D23841





More information about the llvm-commits mailing list