[PATCH] D24168: Refactor LICM pass in preparation for LoopSink pass.

[Xinliang David Li via llvm-commits]

On Thu, Sep 1, 2016 at 5:29 PM, Chandler Carruth <chandlerc at gmail.com> wrote:
> chandlerc added a comment.
>
> In https://reviews.llvm.org/D24168#532233, @danielcdh wrote:
>
>> This is an obvious change, I will commit it without review.
>
>
> So, in the code review where I asked for the change, I mentioned I had some comments that should be attached to it. So that might signify that it isn't fully obvious...
>
> And once you *ask* for a pre-commit review, it seem much more polite to see it through. Comments inbound shortly.


My guess is Dehao misunderstood the comments -- it happens to me to
;). Re-reading your comments, it is now clear what you mean.

David


>
>
> https://reviews.llvm.org/D24168
>
>
>