[PATCH] D24120: [ELF] Do not omit debug sections when computing build-id

[Rui Ueyama via llvm-commits]

ruiu added a comment.

It is unfortunate that this speed hack didn't work.


================
Comment at: ELF/Writer.cpp:1323
@@ -1322,6 +1322,3 @@
 
-  // Compute a hash of all sections except .debug_* sections.
-  // We skip debug sections because they tend to be very large
-  // and their contents are very likely to be the same as long as
-  // other sections are the same.
+  // Compute a hash of all sections.
   uint8_t *Start = Buffer->getBufferStart();
----------------
... of the output file.

================
Comment at: ELF/Writer.cpp:1328
@@ -1337,2 +1327,3 @@
+  Regions.push_back({Start, End});
   Out<ELFT>::BuildId->writeBuildId(Regions);
 }
----------------
Please simplify `writeBuildId` so that it takes just a uint8_t pointer and size instead of an array of arrays.


https://reviews.llvm.org/D24120