[compiler-rt] r280055 - [asan] Mark failing test as UNSUPPORTED.

Akira Hatanaka via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 1 14:55:39 PDT 2016


This test was unexpectedly passing on some bots (I don’t remember if it was i386 or x86_64). I had to fix the bot, and since the comment says it is disabling the test, I thought I can just mark it as UNSUPPORTED. I haven’t tried, but if you want to use XFAIL, perhaps you can mark it as i386-darwin or x86_64-darwin.

> On Sep 1, 2016, at 2:27 PM, Vitaly Buka <vitalybuka at google.com> wrote:
> 
> why is UNSUPPORTED is better than XFAIL?
> 
> On Mon, Aug 29, 2016 at 8:18 PM Akira Hatanaka via llvm-commits <llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>> wrote:
> Author: ahatanak
> Date: Mon Aug 29 22:10:19 2016
> New Revision: 280055
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=280055&view=rev <http://llvm.org/viewvc/llvm-project?rev=280055&view=rev>
> Log:
> [asan] Mark failing test as UNSUPPORTED.
> 
> Modified:
>     compiler-rt/trunk/test/asan/TestCases/use-after-scope-types.cc
> 
> Modified: compiler-rt/trunk/test/asan/TestCases/use-after-scope-types.cc
> URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/asan/TestCases/use-after-scope-types.cc?rev=280055&r1=280054&r2=280055&view=diff <http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/asan/TestCases/use-after-scope-types.cc?rev=280055&r1=280054&r2=280055&view=diff>
> ==============================================================================
> --- compiler-rt/trunk/test/asan/TestCases/use-after-scope-types.cc (original)
> +++ compiler-rt/trunk/test/asan/TestCases/use-after-scope-types.cc Mon Aug 29 22:10:19 2016
> @@ -12,7 +12,7 @@
>  // RUN: not %run %t 10 2>&1 | FileCheck %s
> 
>  // Temporarily disable to fix the bot.
> -// XFAIL: darwin
> +// UNSUPPORTED: darwin
> 
>  #include <stdlib.h>
>  #include <string>
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits <http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160901/db83af38/attachment.html>


More information about the llvm-commits mailing list