[PATCH] D24151: [Legalizer] Don't throw away false low half for GT/LT SETCC

Sanjay Patel via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 1 14:24:00 PDT 2016


spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.

LGTM - but there's a bug in the regression test that needs to be fixed.


================
Comment at: test/CodeGen/X86/pr29170.ll:10
@@ +9,3 @@
+; CHECK: cmpl
+; CHECL: sbbl
+define i32 @main() {
----------------
'CHECL' - use utils/update_test_checks.py to avoid human error? :)


https://reviews.llvm.org/D24151





More information about the llvm-commits mailing list