[PATCH] D24131: Add NewAddressDescription, which can describe any type of address.

[Vitaly Buka via llvm-commits]

vitalybuka added inline comments.

================
Comment at: lib/asan/asan_descriptions.h:176
@@ +175,3 @@
+
+struct NewAddressDescriptionBase {
+  AddressKind kind;
----------------
I don't like union like this, but I missed the background for this changes.
What is the ultimate goal?

================
Comment at: lib/asan/asan_descriptions.h:185
@@ +184,3 @@
+  };
+  uptr Address() {
+    switch (kind) {
----------------
Why not regular C++ e.g. with interface with virtual methods?


================
Comment at: lib/asan/asan_descriptions.h:218
@@ +217,3 @@
+  NewAddressDescription() {
+    kind = kAddressKindWild;
+    addr = 0;
----------------
Just: *this = {};


https://reviews.llvm.org/D24131