[PATCH] D24038: Add ISD::EH_DWARF_CFA, simplify @llvm.eh.dwarf.cfa on Mips, fix on PowerPC

[Eric Christopher via llvm-commits]

echristo added a comment.

Couple of nits. Looks fine otherwise.


================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:5021
@@ +5020,3 @@
+    setValue(&I, DAG.getNode(ISD::EH_DWARF_CFA, sdl,
+                             TLI.getPointerTy(DAG.getDataLayout()),
+                             getValue(I.getArgOperand(0))));
----------------
Weird formatting?

================
Comment at: llvm/trunk/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp:2788
@@ +2787,3 @@
+    SDValue CfaArg = DAG.getSExtOrTrunc(Node->getOperand(0), dl,
+                                        TLI.getPointerTy(DAG.getDataLayout()));
+    SDValue Offset = DAG.getNode(ISD::ADD, dl,
----------------
Ditto.


Repository:
  rL LLVM

https://reviews.llvm.org/D24038