[PATCH] D24132: Remove the old AddressDescription struct

[Vitaly Buka via llvm-commits]

vitalybuka requested changes to this revision.
This revision now requires changes to proceed.

================
Comment at: lib/asan/asan_debugging.cc:82
@@ +81,3 @@
+                                  uptr *region_size_ptr) {
+  NewAddressDescription descr{addr};  // NOLINT
+  uptr region_address = 0;
----------------
could you avoid NOLINT with descr = {addr} ?

================
Comment at: lib/asan/asan_debugging.cc:85
@@ +84,3 @@
+  uptr region_size = 0;
+  const char *region_kind;
+  switch (descr.kind) {
----------------
Could you please add:
const char *region_kind = nullptr;
name[0] = 0;

if any bug in switches below, it would be easiest to debug consistent values

================
Comment at: lib/asan/asan_debugging.cc:86
@@ +85,3 @@
+  const char *region_kind;
+  switch (descr.kind) {
+    case kAddressKindWild:
----------------
what is going to happen if descr.kind is not one of your cases?

if it's impossible, CHECK in default: would be nice.



https://reviews.llvm.org/D24132