[PATCH] D23931: [XRay] ARM 32-bit no-Thumb support in LLVM

Renato Golin via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 1 08:36:32 PDT 2016


rengolin added inline comments.

================
Comment at: test/CodeGen/ARM/xray-attribute-instrumentation.ll:5
@@ +4,3 @@
+; CHECK-LABEL: Lxray_sled_0:
+; CHECK-NEXT:  .ascii "\005\000\000\352"
+; CHECK-NEXT:  .ascii  "\000\360 \343"
----------------
rSerge wrote:
> rengolin wrote:
> > I was expecting Nops...
> The first instruction is a jump over the NOPs. The other 6 instructions are NOPs.
Right, I was referring to the .ascii... When you use builders, this won't happen any more. It will also work in big-endian. :)


https://reviews.llvm.org/D23931





More information about the llvm-commits mailing list