[PATCH] D24128: [ELF] PR30221 - linker script expression parser does not accept '~'

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 1 07:18:35 PDT 2016


grimar added inline comments.

================
Comment at: ELF/LinkerScript.cpp:1237
@@ +1236,3 @@
+  if (Tok.startswith("-"))
+    return Tok.getAsInteger(0, (int64_t &)V);
+  return Tok.getAsInteger(0, V);
----------------
grimar wrote:
> Do you need that cast ?
> Looks both branches do the same ?
Ah I see, it is int, not uint.


Repository:
  rL LLVM

https://reviews.llvm.org/D24128





More information about the llvm-commits mailing list