[PATCH] D24102: [LLVM/Support] - Disallow match() method of llvm::Regex to change object state.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 1 01:23:39 PDT 2016


grimar added inline comments.

================
Comment at: include/llvm/Support/Regex.h:77
@@ -76,3 +76,3 @@
     /// This returns true on a successful match.
-    bool match(StringRef String, SmallVectorImpl<StringRef> *Matches = nullptr);
+    bool match(StringRef String, SmallVectorImpl<StringRef> *Matches = nullptr) const;
 
----------------
btw, code in Regex.h and .cpp is not clang-formatted.
In this patch, formatting can affect on this line, should I format it ?


https://reviews.llvm.org/D24102





More information about the llvm-commits mailing list