[PATCH] D23766: DebugInfo: use strongly typed enum for debug info flags

[David Blaikie via llvm-commits]

dblaikie added inline comments.

================
Comment at: include/llvm/IR/DebugInfoFlags.def:44
@@ -42,1 +43,3 @@
 
+#ifndef NO_DI_FLAG_LARGEST
+// intended to be used with ADT/BitmaskEnum.h
----------------
The double negative seems a bit confusing and this is used in exactly one place - so perhaps it should be opt-in, rather than opt-out. (eg: "ifdef DI_FLAG_LARGEST" and then just define it in the one place it's needed, rather than having to define NO_DI_FLAG_LARGEST in several places)


https://reviews.llvm.org/D23766