[PATCH] D24104: Make GlobalsAA ignore dead constant expressions.

[Michael Kuperstein via llvm-commits]

mkuper added inline comments.

================
Comment at: lib/Analysis/GlobalsModRef.cpp:277
@@ -276,1 +276,3 @@
+      // AnalyzeUsesOfPointer assumes all uses of the value are live.
+      F.removeDeadConstantUsers();
       if (!AnalyzeUsesOfPointer(&F)) {
----------------
Don't know enough about GlobalsAA to approve this anyway, but as a matter of principle - is it acceptable for an analysis pass to modify the IR?


Repository:
  rL LLVM

https://reviews.llvm.org/D24104