[PATCH] D24103: [WIP][peephole] Enhance folding logic to work for STATEPOINTs

Philip Reames via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 31 14:42:03 PDT 2016


reames created this revision.
reames added reviewers: lhames, qcolombet, sanjoy.
reames added a subscriber: llvm-commits.
Herald added subscribers: mcrosier, sanjoy.

This is a rough patch with a bunch of points for discussion.  I'd really appreciate some input with folks familiar with this code.  I've only recently started looking at the MI layer and am very worried that I'm missing key assumptions.  As a starting point, why is this optimizeLoadInstr target specific at all?

The general idea here is to get enough of the existing restrictions out of the way that the already existing folding logic in foldMemoryOperand can kick in for STATEPOINTs and fold references to immutable stack slots.  What worries me is that none of the tests broke when I just removed all the existing restrictions.  :)  



https://reviews.llvm.org/D24103

Files:
  lib/CodeGen/PeepholeOptimizer.cpp
  lib/Target/X86/X86InstrInfo.cpp
  test/CodeGen/X86/statepoint-live-in.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D24103.69907.patch
Type: text/x-patch
Size: 10884 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160831/319a1485/attachment-0001.bin>


More information about the llvm-commits mailing list