[llvm] r280272 - [ResetMachineFunction] Emit the diagnostic isel fallback when asked.

Quentin Colombet via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 31 11:43:01 PDT 2016


Author: qcolombet
Date: Wed Aug 31 13:43:01 2016
New Revision: 280272

URL: http://llvm.org/viewvc/llvm-project?rev=280272&view=rev
Log:
[ResetMachineFunction] Emit the diagnostic isel fallback when asked.

This pass is now able to report when the function is being reset.

Modified:
    llvm/trunk/include/llvm/CodeGen/Passes.h
    llvm/trunk/lib/CodeGen/ResetMachineFunctionPass.cpp

Modified: llvm/trunk/include/llvm/CodeGen/Passes.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/CodeGen/Passes.h?rev=280272&r1=280271&r2=280272&view=diff
==============================================================================
--- llvm/trunk/include/llvm/CodeGen/Passes.h (original)
+++ llvm/trunk/include/llvm/CodeGen/Passes.h Wed Aug 31 13:43:01 2016
@@ -53,7 +53,11 @@ namespace llvm {
   /// using the MIR serialization format.
   MachineFunctionPass *createPrintMIRPass(raw_ostream &OS);
 
-  MachineFunctionPass *createResetMachineFunctionPass();
+  /// This pass resets a MachineFunction when it has the FailedISel property
+  /// as if it was just created.
+  /// If EmitFallbackDiag is true, the pass will emit a
+  /// DiagnosticInfoISelFallback for every MachineFunction it resets.
+  MachineFunctionPass *createResetMachineFunctionPass(bool EmitFallbackDiag);
 
   /// createCodeGenPreparePass - Transform the code to expose more pattern
   /// matching during instruction selection.

Modified: llvm/trunk/lib/CodeGen/ResetMachineFunctionPass.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/ResetMachineFunctionPass.cpp?rev=280272&r1=280271&r2=280272&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/ResetMachineFunctionPass.cpp (original)
+++ llvm/trunk/lib/CodeGen/ResetMachineFunctionPass.cpp Wed Aug 31 13:43:01 2016
@@ -13,6 +13,7 @@
 #include "llvm/CodeGen/Passes.h"
 #include "llvm/CodeGen/MachineFunction.h"
 #include "llvm/CodeGen/MachineFunctionPass.h"
+#include "llvm/IR/DiagnosticInfo.h"
 #include "llvm/Support/Debug.h"
 using namespace llvm;
 
@@ -20,11 +21,14 @@ using namespace llvm;
 
 namespace {
   class ResetMachineFunction : public MachineFunctionPass {
+    /// Tells whether or not this pass should emit a fallback
+    /// diagnostic when it resets a function.
+    bool EmitFallbackDiag;
+
   public:
     static char ID; // Pass identification, replacement for typeid
-    ResetMachineFunction() :
-      MachineFunctionPass(ID) {
-    }
+    ResetMachineFunction(bool EmitFallbackDiag = false)
+        : MachineFunctionPass(ID), EmitFallbackDiag(EmitFallbackDiag) {}
 
     const char *getPassName() const override {
       return "ResetMachineFunction";
@@ -35,6 +39,11 @@ namespace {
               MachineFunctionProperties::Property::FailedISel)) {
         DEBUG(dbgs() << "Reseting: " << MF.getName() << '\n');
         MF.reset();
+        if (EmitFallbackDiag) {
+          const Function &F = *MF.getFunction();
+          DiagnosticInfoISelFallback DiagFallback(F);
+          F.getContext().diagnose(DiagFallback);
+        }
         return true;
       }
       return false;
@@ -48,6 +57,6 @@ INITIALIZE_PASS(ResetMachineFunction, DE
                 "reset machine function if ISel failed", false, false)
 
 MachineFunctionPass *
-llvm::createResetMachineFunctionPass() {
-  return new ResetMachineFunction();
+llvm::createResetMachineFunctionPass(bool EmitFallbackDiag = false) {
+  return new ResetMachineFunction(EmitFallbackDiag);
 }




More information about the llvm-commits mailing list