[PATCH] D24067: [LLVM] Fix some Clang-tidy modernize-use-using and Include What You Use warnings; other minor fixes

[Eugene Zelenko via llvm-commits]

Eugene.Zelenko added inline comments.

================
Comment at: lib/Target/X86/X86ISelLowering.cpp:3561
@@ -3520,3 +3560,3 @@
 
-  int FI = INT_MAX;
+  int FI = std::numeric_limits<int>::max();
   if (Arg.getOpcode() == ISD::CopyFromReg) {
----------------
compnerd wrote:
> What is the benefit of `std::numeric_limits<T>::max()` over `T_MAX`?
This is C++ way of dealing with limits.

================
Comment at: lib/Target/X86/X86ISelLowering.cpp:29854
@@ -29836,2 +29853,3 @@
     // Perform one or more big stores into memory.
-    for (unsigned i=0, e=(ToSz*NumElems)/StoreType.getSizeInBits(); i!=e; ++i) {
+    for (unsigned i = 0, e = (ToSz*NumElems)/StoreType.getSizeInBits(); i != e;
+         ++i) {
----------------
compnerd wrote:
> Why not fix the infix operators here?
Did you mean adding spaces between operands ans operators?

I was not sure about that, because I encountered such style (no spaces) in other places.


Repository:
  rL LLVM

https://reviews.llvm.org/D24067