[PATCH] D24014: [codeview] Add new directives to record inlined call site line info

[David Majnemer via llvm-commits]

majnemer added inline comments.

================
Comment at: lib/MC/MCParser/AsmParser.cpp:3257-3258
@@ +3256,4 @@
+                    "expected function id in '.cv_func_id' directive") ||
+      check(FunctionId < 0, FunctionIdLoc,
+            "function id less than zero") ||
+      parseToken(AsmToken::EndOfStatement,
----------------
Should we also check that it is < UNSIGNED_MAX ?

================
Comment at: lib/MC/MCParser/AsmParser.cpp:3288
@@ +3287,3 @@
+                    "expected function id in '.cv_inline_site_id' directive") ||
+      check(FunctionId < 0, FunctionIdLoc, "function id less than zero"))
+    return true;
----------------
Ditto.

================
Comment at: lib/MC/MCParser/AsmParser.cpp:3311
@@ +3310,3 @@
+  // IAFile IALine
+  if (parseIntToken(IAFile, "expected file id after 'inlined_at'") ||
+      parseIntToken(IALine, "expected line number after 'inlined_at'"))
----------------
Dow we want to validate using isValidFileNumber?


https://reviews.llvm.org/D24014