[PATCH] D23313: X86: FMA intrinsic + FNEG - sequence optimization

[Sanjay Patel via llvm-commits]

spatel added a comment.

Should there be some tests for scalar double and packed double as well?


================
Comment at: ../lib/Target/X86/X86ISelLowering.cpp:4872
@@ -4871,3 +4871,3 @@
 
-  auto *MaskLoad = dyn_cast<LoadSDNode>(MaskNode);
+  auto *MaskLoad = dyn_cast<LoadSDNode>(Op);
   if (!MaskLoad)
----------------
MaskLoad -> Load ?

================
Comment at: ../lib/Target/X86/X86ISelLowering.cpp:4881
@@ -4880,3 +4880,3 @@
 
   auto *MaskCP = dyn_cast<ConstantPoolSDNode>(Ptr);
   if (!MaskCP || MaskCP->isMachineConstantPoolEntry())
----------------
MaskCP -> ConstantPoolNode ?


Repository:
  rL LLVM

https://reviews.llvm.org/D23313