[PATCH] D23768: [ELF] Linkerscript: eliminate LayoutInputSection

[Eugene Leviant via llvm-commits]

evgeny777 added inline comments.

================
Comment at: ELF/LinkerScript.cpp:214-217
@@ -257,1 +213,6 @@
+    for (InputSectionBase<ELFT> *S : V)
+      if (S->OutSec == nullptr) {
+        Ret.push_back(S);
+        S->OutSec = reinterpret_cast<OutputSectionBase<ELFT> *>(-1ULL);
+      }
   }
----------------
ruiu wrote:
> Setting -1 to the pointer to record whether an input section is added or not is an unintended use of the pointer and pretty confusing. Please use a DenseSet to uniquefy.
This will cause growth of memory consumption and slightly slow down things. May be using some fake output section is better?

```
OutputSectionBase<ELFT> FakeSec;
for (InputSectionBase<ELFT> *S : V)
      if (!S->OutSec) {
         Ret.push_back(S);
         S->OutSec = &FakeSec;
      }
```


https://reviews.llvm.org/D23768