[llvm] r279417 - [LTO] Handles commons in monolithic LTO

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 31 07:00:33 PDT 2016


On 29 August 2016 at 17:07, Rafael EspĂ­ndola <rafael.espindola at gmail.com> wrote:
>> +    // Common resolution: collect the maximum size/alignment.
>> +    // FIXME: right now we ignore the prevailing information, it is not clear
>> +    // what is the "right" behavior here.
>
> I think the correct behaviour is to expect the linker to keep as
> prevailing the GV with the largest size and for the linker to update
> the alignment.
>
> The rationale is that is that keeping the largest avoids the need for
> RAUW since the alignment can be set in place.

I just implemented this in lld (r280242).

Cheers,
Rafael


More information about the llvm-commits mailing list