[PATCH] D24071: [compiler-rt] [builtins] Allow building the necessary ARM builtins for MSVC mode with cmake
Renato Golin via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 31 03:12:34 PDT 2016
rengolin requested changes to this revision.
rengolin added a comment.
This revision now requires changes to proceed.
I don't think this fix is correct. We shouldn't be *adding* GNU functions to Windows, but we should be making Clang on Windows emit the right EABI calls.
The way to fix this is to associate those functions in ARMISelLowering, just like we do for EABI.
cheers,
--renato
https://reviews.llvm.org/D24071
More information about the llvm-commits
mailing list