[PATCH] D23906: LSV: Fix incorrectly increasing alignment

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 30 17:58:53 PDT 2016


arsenm added inline comments.

================
Comment at: lib/Transforms/Vectorize/LoadStoreVectorizer.cpp:799
@@ +798,3 @@
+                                                   StackAdjustedAlignment,
+                                                   DL, S0, nullptr, &DT);
+    if (NewAlign <= Alignment)
----------------
efriedma wrote:
> I'm sort of confused about what you're doing here... what is StackAdjustedAlignment supposed to be?
It's supposed to be a normal "good" stack alignment value that will generally allow vectorization. It's a hardcoded 4 because the GPUs we care about this always works. This should be something smarter, but that's a separate change


https://reviews.llvm.org/D23906





More information about the llvm-commits mailing list