[PATCH] D24000: [experimental] Add support for live-in semantics of values in deopt bundles

[Sanjoy Das via llvm-commits]

sanjoy accepted this revision.
sanjoy added a comment.
This revision is now accepted and ready to land.

lgtm with a couple of minor typos pointed out inline


================
Comment at: lib/CodeGen/SelectionDAG/StatepointLowering.cpp:461
@@ +460,3 @@
+  // "live-out", and live throughout the lifetime of the call (i.e. we can find
+  // it from any PC within the transative callee of the statepoint).  In
+  // particularly, if the callee spills callee preserved registers we may not
----------------
s/transative/transitive/

================
Comment at: lib/CodeGen/SelectionDAG/StatepointLowering.cpp:462
@@ +461,3 @@
+  // it from any PC within the transative callee of the statepoint).  In
+  // particularly, if the callee spills callee preserved registers we may not
+  // be able to find a value placed in that register during the call.  This is
----------------
s/particularly/particular/

================
Comment at: lib/CodeGen/SelectionDAG/StatepointLowering.cpp:465
@@ +464,3 @@
+  // fine for live-out, but not for live-through.  If we were willing to make
+  // assumptions about the code generate producing the callee, we could
+  // potentially allow live-through values in callee saved registers.
----------------
s/code generate/code generator/


https://reviews.llvm.org/D24000