[PATCH] D24044: CodeGen: Tail-duplicate longer blocks that end with indirect branches.

Kyle Butt via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 30 15:06:53 PDT 2016


iteratee marked an inline comment as done.

================
Comment at: lib/CodeGen/TailDuplicator.cpp:569
@@ +568,3 @@
+    // branches that occur within a function, so we check for local successors.
+    HasLocalIndirectbr = back.isIndirectBranch() && TailBB.succ_size() != 0;
+  }
----------------
davidxl wrote:
> I asked the question before: can you use  back.isIndirectBranch() && !back.isReturn() ?
> 
Sorry if the reply got lost in splitting this out.
I checked, and no, that's not something that works. There are platforms where lowered returns don't set isReturn()

It's unfortunate, but it's what's there.


Repository:
  rL LLVM

https://reviews.llvm.org/D24044





More information about the llvm-commits mailing list