[PATCH] D23766: DebugInfo: use strongly typed enum for debug info flags

Victor via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 30 14:13:41 PDT 2016


vleschuk retitled this revision from "DebugInfo: introduce DIFlagsUnderlying type for debug info flags" to "DebugInfo: use strongly typed enum for debug info flags".
vleschuk updated the summary for this revision.
vleschuk updated this revision to Diff 69753.
vleschuk added a comment.

- Switched to ADT/BitmaskEnum for DIFlags
- Added "special" flags: FlagLargest and FlagZero (FlagLargest can be disabled in DebugInfoFlags.def to avoid problems with duplicate cases in switch statements)
- For types derived from DINode added several overloaded methods which take either underlying enum type or enum itself. This was done to avoid lots of static_casts in other modules.
- Edited tests to use DIFlags


https://reviews.llvm.org/D23766

Files:
  include/llvm/IR/DIBuilder.h
  include/llvm/IR/DebugInfoFlags.def
  include/llvm/IR/DebugInfoMetadata.h
  lib/Bitcode/Reader/BitcodeReader.cpp
  lib/IR/AsmWriter.cpp
  lib/IR/DIBuilder.cpp
  lib/IR/DebugInfoMetadata.cpp
  unittests/IR/DebugInfoTest.cpp
  unittests/IR/IRBuilderTest.cpp
  unittests/IR/MetadataTest.cpp
  unittests/Transforms/Utils/Cloning.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D23766.69753.patch
Type: text/x-patch
Size: 63768 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160830/b5a436c0/attachment.bin>


More information about the llvm-commits mailing list