[PATCH] D24029: Split ScarinessScore between its "storage" (POD), and an initializing object.

[Filipe Cabecinhas via llvm-commits]

filcab created this revision.
filcab added reviewers: kcc, samsonov.
filcab added a subscriber: llvm-commits.
Herald added a subscriber: kubabrecka.

This is needed so we can use it for D23672 on VS2013, since this VS
version doesn't support unrestricted unions, and doesn't allow us to
uses an object without a trivial default constructor inside a union.

https://reviews.llvm.org/D24029

Files:
  lib/asan/asan_scariness_score.h

Index: lib/asan/asan_scariness_score.h
===================================================================
--- lib/asan/asan_scariness_score.h
+++ lib/asan/asan_scariness_score.h
@@ -34,10 +34,10 @@
 #include "sanitizer_common/sanitizer_libc.h"
 
 namespace __asan {
-class ScarinessScore {
- public:
-  ScarinessScore() {
+struct ScarinessScoreBase {
+  void Clear() {
     descr[0] = 0;
+    score = 0;
   }
   void Scare(int add_to_score, const char *reason) {
     if (descr[0])
@@ -52,16 +52,23 @@
       Printf("SCARINESS: %d (%s)\n", score, descr);
   }
   static void PrintSimple(int score, const char *descr) {
-    ScarinessScore SS;
-    SS.Scare(score, descr);
-    SS.Print();
+    ScarinessScoreBase SSB;
+    SSB.Clear();
+    SSB.Scare(score, descr);
+    SSB.Print();
   }
 
  private:
-  int score = 0;
+  int score;
   char descr[1024];
 };
 
+struct ScarinessScore : ScarinessScoreBase {
+  ScarinessScore() {
+    Clear();
+  }
+};
+
 }  // namespace __asan
 
 #endif  // ASAN_SCARINESS_SCORE_H


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D24029.69690.patch
Type: text/x-patch
Size: 1016 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160830/2c712535/attachment.bin>