[PATCH] D24009: [LoopVectorizer] Support predicating instructions in blocks with several input edges

Matthew Simpson via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 30 07:32:14 PDT 2016


mssimpso added a comment.

This looks reasonable to me, but I have a question about the test case (see the inline comment). I too cannot say why the original conditional stores patch limited this to single-predecessor blocks.


================
Comment at: test/Transforms/LoopVectorize/if-pred-non-void.ll:197
@@ +196,3 @@
+
+if.then:                                          ; preds = %for.body
+  %sd1 = sdiv i32 %psd, %lsd
----------------
Is the test checking what you want it to? I was expecting if.then to have more than one predecessor (and trigger the assert) since it's the block with the sdiv's.


https://reviews.llvm.org/D24009





More information about the llvm-commits mailing list