[PATCH] D24026: consistently add \n to log and trace messages

Ed Maste via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 30 06:44:58 PDT 2016


emaste created this revision.
emaste added reviewers: compnerd, kledzik.
emaste added a subscriber: llvm-commits.
Herald added a subscriber: emaste.

Previously most messages included a newline, but a few of them were missing. Fix these and simplify by just adding the newline in the _LIBUNWIND_LOG macro itself.

Example output from unpatched libunwind, from https://lists.freebsd.org/pipermail/freebsd-ports/2016-August/104595.html:
```
libuwind: _unw_add_dynamic_fde: bad fde: FDE is really a CIElibuwind:
_unw_add_dynamic_fde: bad fde: FDE is really a CIElibuwind:
_unw_add_dynamic_fde: bad fde: FDE is really a CIElibuwind:

```


https://reviews.llvm.org/D24026

Files:
  src/AddressSpace.hpp
  src/CompactUnwinder.hpp
  src/EHHeaderParser.hpp
  src/Unwind-EHABI.cpp
  src/Unwind-sjlj.c
  src/UnwindCursor.hpp
  src/UnwindLevel1-gcc-ext.c
  src/UnwindLevel1.c
  src/config.h
  src/libunwind.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D24026.69672.patch
Type: text/x-patch
Size: 58620 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160830/3af5aafd/attachment-0001.bin>


More information about the llvm-commits mailing list