[PATCH] D23661: [ELF] Fix sorting in combrelocs mode and add DT_REL(A)COUNT to .dynamic

Eugene Leviant via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 30 05:23:59 PDT 2016


Rafael, it splits relocation process into two phases. The first one is
applying relative relocs in a tight loop and
the second one handles all other reloc types. Without DT_REL(A)COUNT tag it
simply ignores all relative relocations,
Unfortunately I can't change the dynamic linker sources, but it works fine
with images linked with gold and ld.

Thanks,
Eugene


2016-08-30 0:21 GMT+03:00 Rafael EspĂ­ndola <rafael.espindola at gmail.com>:

> On 29 August 2016 at 17:11, Rui Ueyama <ruiu at google.com> wrote:
> > Yes, it says that the field is optional, but it doesn't say that it
> should
> > be interpreted as zero if absent. So it seems to me that writing zero is
> the
> > right thing if it is actually zero.
>
> This is fine by me. The reason being that this field exists to support
> an optimization. If the field is missing or is zero, the result has to
> be the same: there is nothing to optimize.
>
> Eugene, can you say how your dynamic linker uses this? Last time we
> tried it had no impact on load times with glibc.
>
> Cheers,
> Rafael
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160830/9c86f60e/attachment.html>


More information about the llvm-commits mailing list