[llvm] r280052 - [RewriteStatepointsForGC] Update comment for same PHI node check. NFC

Anna Thomas via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 29 19:36:48 PDT 2016


Author: annat
Date: Mon Aug 29 21:36:48 2016
New Revision: 280052

URL: http://llvm.org/viewvc/llvm-project?rev=280052&view=rev
Log:
[RewriteStatepointsForGC] Update comment for same PHI node check. NFC

Modified:
    llvm/trunk/lib/Transforms/Scalar/RewriteStatepointsForGC.cpp

Modified: llvm/trunk/lib/Transforms/Scalar/RewriteStatepointsForGC.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/RewriteStatepointsForGC.cpp?rev=280052&r1=280051&r2=280052&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/Scalar/RewriteStatepointsForGC.cpp (original)
+++ llvm/trunk/lib/Transforms/Scalar/RewriteStatepointsForGC.cpp Mon Aug 29 21:36:48 2016
@@ -1805,7 +1805,8 @@ static bool findRematerializableChainToB
   // conflict, and hence an additional phi with the same incoming values get
   // generated. We need to identify the BaseValue (.base version of phi) and
   // CurrentValue (the phi node itself) as the same, so that we can
-  // rematerialize the gep and casts below.
+  // rematerialize the gep and casts below. This is a workaround for the
+  // deficieny in the findBasePointer algorithm.
   if (PHINode *CurrentPhi = dyn_cast<PHINode>(CurrentValue))
     if (PHINode *BasePhi = dyn_cast<PHINode>(BaseValue)) {
       auto PhiNum = CurrentPhi->getNumIncomingValues();




More information about the llvm-commits mailing list