[llvm] r279988 - GlobalISel: legalize frem to a libcall on AArch64.
Tim Northover via llvm-commits
llvm-commits at lists.llvm.org
Mon Aug 29 12:07:16 PDT 2016
Author: tnorthover
Date: Mon Aug 29 14:07:16 2016
New Revision: 279988
URL: http://llvm.org/viewvc/llvm-project?rev=279988&view=rev
Log:
GlobalISel: legalize frem to a libcall on AArch64.
Modified:
llvm/trunk/include/llvm/CodeGen/GlobalISel/CallLowering.h
llvm/trunk/include/llvm/CodeGen/GlobalISel/MachineLegalizeHelper.h
llvm/trunk/lib/CodeGen/GlobalISel/MachineLegalizeHelper.cpp
llvm/trunk/lib/CodeGen/GlobalISel/MachineLegalizer.cpp
llvm/trunk/lib/Target/AArch64/AArch64CallLowering.cpp
llvm/trunk/lib/Target/AArch64/AArch64CallLowering.h
llvm/trunk/lib/Target/AArch64/AArch64MachineLegalizer.cpp
llvm/trunk/test/CodeGen/AArch64/GlobalISel/legalize-rem.mir
Modified: llvm/trunk/include/llvm/CodeGen/GlobalISel/CallLowering.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/CodeGen/GlobalISel/CallLowering.h?rev=279988&r1=279987&r2=279988&view=diff
==============================================================================
--- llvm/trunk/include/llvm/CodeGen/GlobalISel/CallLowering.h (original)
+++ llvm/trunk/include/llvm/CodeGen/GlobalISel/CallLowering.h Mon Aug 29 14:07:16 2016
@@ -88,9 +88,9 @@ class CallLowering {
/// needs to be passed.
///
/// \return true if the lowering succeeded, false otherwise.
- virtual bool lowerCall(MachineIRBuilder &MIRBuilder, MachineOperand &Callee,
- ArrayRef<MVT> ResTys, ArrayRef<unsigned> ResRegs,
- ArrayRef<MVT> ArgTys,
+ virtual bool lowerCall(MachineIRBuilder &MIRBuilder,
+ const MachineOperand &Callee, ArrayRef<MVT> ResTys,
+ ArrayRef<unsigned> ResRegs, ArrayRef<MVT> ArgTys,
ArrayRef<unsigned> ArgRegs) const {
return false;
}
Modified: llvm/trunk/include/llvm/CodeGen/GlobalISel/MachineLegalizeHelper.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/CodeGen/GlobalISel/MachineLegalizeHelper.h?rev=279988&r1=279987&r2=279988&view=diff
==============================================================================
--- llvm/trunk/include/llvm/CodeGen/GlobalISel/MachineLegalizeHelper.h (original)
+++ llvm/trunk/include/llvm/CodeGen/GlobalISel/MachineLegalizeHelper.h Mon Aug 29 14:07:16 2016
@@ -61,6 +61,9 @@ public:
LegalizeResult legalizeInstr(MachineInstr &MI,
const MachineLegalizer &Legalizer);
+ /// Legalize an instruction by emiting a runtime library call instead.
+ LegalizeResult libcall(MachineInstr &MI);
+
/// Legalize an instruction by reducing the width of the underlying scalar
/// type.
LegalizeResult narrowScalar(MachineInstr &MI, unsigned TypeIdx, LLT NarrowTy);
Modified: llvm/trunk/lib/CodeGen/GlobalISel/MachineLegalizeHelper.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/GlobalISel/MachineLegalizeHelper.cpp?rev=279988&r1=279987&r2=279988&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/GlobalISel/MachineLegalizeHelper.cpp (original)
+++ llvm/trunk/lib/CodeGen/GlobalISel/MachineLegalizeHelper.cpp Mon Aug 29 14:07:16 2016
@@ -14,10 +14,12 @@
//===----------------------------------------------------------------------===//
#include "llvm/CodeGen/GlobalISel/MachineLegalizeHelper.h"
+#include "llvm/CodeGen/GlobalISel/CallLowering.h"
#include "llvm/CodeGen/GlobalISel/MachineLegalizer.h"
#include "llvm/CodeGen/MachineRegisterInfo.h"
#include "llvm/Support/Debug.h"
#include "llvm/Support/raw_ostream.h"
+#include "llvm/Target/TargetLowering.h"
#include "llvm/Target/TargetSubtargetInfo.h"
#include <sstream>
@@ -38,6 +40,8 @@ MachineLegalizeHelper::legalizeInstrStep
switch (std::get<0>(Action)) {
case MachineLegalizer::Legal:
return AlreadyLegal;
+ case MachineLegalizer::Libcall:
+ return libcall(MI);
case MachineLegalizer::NarrowScalar:
return narrowScalar(MI, std::get<1>(Action), std::get<2>(Action));
case MachineLegalizer::WidenScalar:
@@ -90,6 +94,30 @@ void MachineLegalizeHelper::extractParts
}
MachineLegalizeHelper::LegalizeResult
+MachineLegalizeHelper::libcall(MachineInstr &MI) {
+ unsigned Size = MI.getType().getSizeInBits();
+ MIRBuilder.setInstr(MI);
+
+ switch (MI.getOpcode()) {
+ default:
+ return UnableToLegalize;
+ case TargetOpcode::G_FREM: {
+ MVT Ty = MVT::getFloatingPointVT(MI.getType().getSizeInBits());
+ auto &CLI = *MIRBuilder.getMF().getSubtarget().getCallLowering();
+ auto &TLI = *MIRBuilder.getMF().getSubtarget().getTargetLowering();
+ const char *Name =
+ TLI.getLibcallName(Size == 64 ? RTLIB::REM_F64 : RTLIB::REM_F32);
+
+ CLI.lowerCall(MIRBuilder, MachineOperand::CreateES(Name), Ty,
+ MI.getOperand(0).getReg(), {Ty, Ty},
+ {MI.getOperand(1).getReg(), MI.getOperand(2).getReg()});
+ MI.eraseFromParent();
+ return Legalized;
+ }
+ }
+}
+
+MachineLegalizeHelper::LegalizeResult
MachineLegalizeHelper::narrowScalar(MachineInstr &MI, unsigned TypeIdx,
LLT NarrowTy) {
// FIXME: Don't know how to handle secondary types yet.
Modified: llvm/trunk/lib/CodeGen/GlobalISel/MachineLegalizer.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/GlobalISel/MachineLegalizer.cpp?rev=279988&r1=279987&r2=279988&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/GlobalISel/MachineLegalizer.cpp (original)
+++ llvm/trunk/lib/CodeGen/GlobalISel/MachineLegalizer.cpp Mon Aug 29 14:07:16 2016
@@ -127,6 +127,7 @@ LLT MachineLegalizer::findLegalType(cons
llvm_unreachable("Cannot find legal type");
case Legal:
case Lower:
+ case Libcall:
return Aspect.Type;
case NarrowScalar: {
return findLegalType(Aspect,
Modified: llvm/trunk/lib/Target/AArch64/AArch64CallLowering.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/AArch64/AArch64CallLowering.cpp?rev=279988&r1=279987&r2=279988&view=diff
==============================================================================
--- llvm/trunk/lib/Target/AArch64/AArch64CallLowering.cpp (original)
+++ llvm/trunk/lib/Target/AArch64/AArch64CallLowering.cpp Mon Aug 29 14:07:16 2016
@@ -131,7 +131,7 @@ bool AArch64CallLowering::lowerFormalArg
}
bool AArch64CallLowering::lowerCall(MachineIRBuilder &MIRBuilder,
- MachineOperand &Callee,
+ const MachineOperand &Callee,
ArrayRef<MVT> ResTys,
ArrayRef<unsigned> ResRegs,
ArrayRef<MVT> ArgTys,
Modified: llvm/trunk/lib/Target/AArch64/AArch64CallLowering.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/AArch64/AArch64CallLowering.h?rev=279988&r1=279987&r2=279988&view=diff
==============================================================================
--- llvm/trunk/lib/Target/AArch64/AArch64CallLowering.h (original)
+++ llvm/trunk/lib/Target/AArch64/AArch64CallLowering.h Mon Aug 29 14:07:16 2016
@@ -34,7 +34,7 @@ class AArch64CallLowering: public CallLo
const Function::ArgumentListType &Args,
ArrayRef<unsigned> VRegs) const override;
- bool lowerCall(MachineIRBuilder &MIRBuilder, MachineOperand &Callee,
+ bool lowerCall(MachineIRBuilder &MIRBuilder, const MachineOperand &Callee,
ArrayRef<MVT> ResTys, ArrayRef<unsigned> ResRegs,
ArrayRef<MVT> ArgTys,
ArrayRef<unsigned> ArgRegs) const override;
Modified: llvm/trunk/lib/Target/AArch64/AArch64MachineLegalizer.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/AArch64/AArch64MachineLegalizer.cpp?rev=279988&r1=279987&r2=279988&view=diff
==============================================================================
--- llvm/trunk/lib/Target/AArch64/AArch64MachineLegalizer.cpp (original)
+++ llvm/trunk/lib/Target/AArch64/AArch64MachineLegalizer.cpp Mon Aug 29 14:07:16 2016
@@ -66,6 +66,9 @@ AArch64MachineLegalizer::AArch64MachineL
for (auto Ty : {s32, s64})
setAction({BinOp, Ty}, Legal);
+ setAction({G_FREM, s32}, Libcall);
+ setAction({G_FREM, s64}, Libcall);
+
for (auto MemOp : {G_LOAD, G_STORE}) {
for (auto Ty : {s8, s16, s32, s64})
setAction({MemOp, Ty}, Legal);
Modified: llvm/trunk/test/CodeGen/AArch64/GlobalISel/legalize-rem.mir
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/AArch64/GlobalISel/legalize-rem.mir?rev=279988&r1=279987&r2=279988&view=diff
==============================================================================
--- llvm/trunk/test/CodeGen/AArch64/GlobalISel/legalize-rem.mir (original)
+++ llvm/trunk/test/CodeGen/AArch64/GlobalISel/legalize-rem.mir Mon Aug 29 14:07:16 2016
@@ -21,6 +21,8 @@ registers:
- { id: 6, class: _ }
- { id: 7, class: _ }
- { id: 8, class: _ }
+ - { id: 9, class: _ }
+ - { id: 10, class: _ }
body: |
bb.0.entry:
liveins: %x0, %x1, %x2, %x3
@@ -49,4 +51,16 @@ body: |
%7(8) = G_TRUNC { s8, s64 } %1
%8(8) = G_SREM s8 %6, %7
+ ; CHECK: %d0 = COPY %0
+ ; CHECK: %d1 = COPY %1
+ ; CHECK: BL $fmod, csr_aarch64_aapcs, implicit-def %lr, implicit %sp, implicit %d0, implicit %d1, implicit-def %d0
+ ; CHECK: %9(64) = COPY %d0
+ %9(64) = G_FREM s64 %0, %1
+
+ ; CHECK: %s0 = COPY %3
+ ; CHECK: %s1 = COPY %4
+ ; CHECK: BL $fmodf, csr_aarch64_aapcs, implicit-def %lr, implicit %sp, implicit %s0, implicit %s1, implicit-def %s0
+ ; CHECK: %10(32) = COPY %s0
+ %10(32) = G_FREM s32 %3, %4
+
...
More information about the llvm-commits
mailing list