[llvm] r279977 - [gold] Fix test accidentally regressed for newer gold

[Teresa Johnson via llvm-commits]

Author: tejohnson
Date: Mon Aug 29 11:22:23 2016
New Revision: 279977

URL: http://llvm.org/viewvc/llvm-project?rev=279977&view=rev
Log:
[gold] Fix test accidentally regressed for newer gold

With r279911 I accidentally regressed the gold/X86/start-lib-common.ll
test for newer golds (v1.12+) that honor the --start-lib/--end-lib.
Remove the alignment which should not be there to make this work with
both old and new gold linkers.

Additionally, now that we have a subdirectory for v1.12+ gold tests,
copy this test there and check specifically for the v1.12+ behavior.

Added:
    llvm/trunk/test/tools/gold/X86/v1.12/Inputs/start-lib-common.ll
    llvm/trunk/test/tools/gold/X86/v1.12/start-lib-common.ll
      - copied, changed from r279974, llvm/trunk/test/tools/gold/X86/start-lib-common.ll
Modified:
    llvm/trunk/test/tools/gold/X86/start-lib-common.ll

Modified: llvm/trunk/test/tools/gold/X86/start-lib-common.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/gold/X86/start-lib-common.ll?rev=279977&r1=279976&r2=279977&view=diff
==============================================================================
--- llvm/trunk/test/tools/gold/X86/start-lib-common.ll (original)
+++ llvm/trunk/test/tools/gold/X86/start-lib-common.ll Mon Aug 29 11:22:23 2016
@@ -19,4 +19,4 @@
 
 ; Check that the common symbol is not dropped completely, which was a regression
 ; in r262676.
-; CHECK: @x = common global i32 0, align 8
+; CHECK: @x = common global i32 0, align

Added: llvm/trunk/test/tools/gold/X86/v1.12/Inputs/start-lib-common.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/gold/X86/v1.12/Inputs/start-lib-common.ll?rev=279977&view=auto
==============================================================================
--- llvm/trunk/test/tools/gold/X86/v1.12/Inputs/start-lib-common.ll (added)
+++ llvm/trunk/test/tools/gold/X86/v1.12/Inputs/start-lib-common.ll Mon Aug 29 11:22:23 2016
@@ -0,0 +1 @@
+ at x = common global i32 0, align 8

Copied: llvm/trunk/test/tools/gold/X86/v1.12/start-lib-common.ll (from r279974, llvm/trunk/test/tools/gold/X86/start-lib-common.ll)
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/gold/X86/v1.12/start-lib-common.ll?p2=llvm/trunk/test/tools/gold/X86/v1.12/start-lib-common.ll&p1=llvm/trunk/test/tools/gold/X86/start-lib-common.ll&r1=279974&r2=279977&rev=279977&view=diff
==============================================================================
--- llvm/trunk/test/tools/gold/X86/start-lib-common.ll (original)
+++ llvm/trunk/test/tools/gold/X86/v1.12/start-lib-common.ll Mon Aug 29 11:22:23 2016
@@ -11,12 +11,6 @@
 
 @x = common global i32 0, align 4
 
-; ToT gold (as of 03/2016) honors --start-lib/--end-lib, drops %t2.o and ends up
+; v1.12 gold honors --start-lib/--end-lib, drops %t2.o and ends up
 ; with (i32 align 4) symbol.
-; Older gold does not drop %t2.o and ends up with (i32 align 8) symbol. This is
-; incorrect behavior, but this test does not verify this in order to support
-; both old and new gold.
-
-; Check that the common symbol is not dropped completely, which was a regression
-; in r262676.
-; CHECK: @x = common global i32 0, align 8
+; CHECK: @x = common global i32 0, align 4