[PATCH] D22956: Ajust two tests implementation of TargetParserTest

[jojo.ma via llvm-commits]

jojo abandoned this revision.
jojo added a comment.



> > 2. Add option AEK_LAST to enum ArchExtKind,then iterate to AEK_LAST.(biggest change, I prefer this one)

> 

> 

> Me too. But I'm still not convinced the two additional tests (ARMArchExtName, ARMHWDivName) add anything of value.

> 

> If we make a mistake in the enum, the test will still pass, since both the enum and the test array are generated from the same source (the .def file).

> 

> We're already testing the extensions in ARMArchExtFeature, so why not just leave it at that?


Indeed, agree. 
For now it's ok leave it at that. Add additional test cases when there is really a need later on.
In a more reasonable way of course.

Thanks renato and djasper!


https://reviews.llvm.org/D22956