[PATCH] D23549: [SROA] Preserve llvm.mem.parallel_loop_access metadata

Hal Finkel via llvm-commits llvm-commits at lists.llvm.org
Sat Aug 27 14:32:44 PDT 2016


hfinkel added a comment.

> SROA doesn't preserve the llvm.mem.parallel_loop_access metadata when it transforms loads/stores.

>  (This patch is not a systematic effort to catch all the cases missed by SROA, but it at least covers those exposed by this testcase / by PR28981).


The higher-level questions here clearly seem to be:

1. Does SROA every do anything that will add loop-carried dependencies? If not, we could do this everywhere.
2. Does SROA also drop AA metadata we should be preserving in the same circumstances? I only see metadata handling in speculatePHINodeLoads and speculateSelectInstLoads, but nowhere else.


https://reviews.llvm.org/D23549





More information about the llvm-commits mailing list