[PATCH] D22840: Split the store of an int value merged from a pair of smaller values into multiple stores.
Chandler Carruth via llvm-commits
llvm-commits at lists.llvm.org
Fri Aug 26 22:52:01 PDT 2016
chandlerc added a comment.
Hmmm. I'm not seeing the updated test cases? Not sure if phabricator is just not updating for me or what though...
================
Comment at: lib/Target/X86/X86ISelLowering.h:778-780
@@ +777,5 @@
+ if (Opd.getValueType().isFloatingPoint())
+ return true;
+ }
+ // If the pair only contains int values, we will save two bitwise
+ // instructions and increase one store instruction. The benefit is
----------------
I agree the cost will be low, I just think it makes sense to mention the different aspects (for example, saving an entry in the store buffer).
Repository:
rL LLVM
https://reviews.llvm.org/D22840
More information about the llvm-commits
mailing list