[PATCH] D23946: [ThinLTO] Move loading of cache entry to client

[Mehdi AMINI via llvm-commits]

mehdi_amini added inline comments.

================
Comment at: llvm/trunk/include/llvm/LTO/Caching.h:25
@@ -24,3 +24,3 @@
 /// Type for client-supplied callback when a buffer is loaded from the cache.
-typedef std::function<void(std::unique_ptr<MemoryBuffer>)> AddBufferFn;
+typedef std::function<void(std::string)> AddBufferFn;
 
----------------
(I thought I commented inline when approving the revision, but didn't get through apparently)

Any reason not to use StringRef?
Or a const ref at minima?


Repository:
  rL LLVM

https://reviews.llvm.org/D23946