[PATCH] D23785: AMDGPU: Remove unneeded implicit exec defs

Tom Stellard via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 26 18:27:29 PDT 2016


tstellarAMD accepted this revision.
tstellarAMD added a comment.
This revision is now accepted and ready to land.

LGTM.


================
Comment at: lib/Target/AMDGPU/SIInstructions.td:1815-1820
@@ -1816,8 +1814,8 @@
 
-def SI_IF: PseudoInstSI <
+def SI_IF: CFPseudoInstSI <
   (outs SReg_64:$dst), (ins SReg_64:$vcc, brtarget:$target),
-  [(set i64:$dst, (int_amdgcn_if i1:$vcc, bb:$target))]> {
+  [(set i64:$dst, (int_amdgcn_if i1:$vcc, bb:$target))], 1, 1> {
   let Constraints = "";
   let Size = 8;
 }
 
----------------
arsenm wrote:
> tstellarAMD wrote:
> > Doesn't this expand to something that read/writes exec?
> Yes. It still does here, it just sets the bit to CFPseudoInstSI instead of using the let blocks
OK, I see.


https://reviews.llvm.org/D23785





More information about the llvm-commits mailing list