[PATCH] D23688: AMDGPU/SI: Implement a custom MachineSchedStrategy

[Matt Arsenault via llvm-commits]

arsenm added a comment.

LGTM


================
Comment at: lib/Target/AMDGPU/GCNSchedStrategy.cpp:9-12
@@ +8,6 @@
+//===----------------------------------------------------------------------===//
+//
+/// \file
+///
+//===----------------------------------------------------------------------===//
+
----------------
Should remove the empty file comment or add something

================
Comment at: lib/Target/AMDGPU/GCNSchedStrategy.cpp:175
@@ +174,3 @@
+  case GenericSchedulerBase::RegExcess:
+    return -1 * Reason;
+ }
----------------
This can be just -Reason


https://reviews.llvm.org/D23688