[PATCH] D23564: [RISCV 7/10] Add RISCVInstPrinter and basic MC assembler tests

Tim Northover via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 26 14:56:02 PDT 2016

Previous message: [PATCH] D23564: [RISCV 7/10] Add RISCVInstPrinter and basic MC assembler tests
Next message: [PATCH] D23557: [RISCV 1/10] Recognise riscv32 and riscv64 in triple parsing code
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

t.p.northover added a subscriber: t.p.northover.
t.p.northover added a comment.

Shouldn't we be testing the code we're adding here? At the moment we seem to be adding support for InstPrinter but only testing MCTargetDesc (the encodings) & AsmPrinter code.


https://reviews.llvm.org/D23564

Previous message: [PATCH] D23564: [RISCV 7/10] Add RISCVInstPrinter and basic MC assembler tests
Next message: [PATCH] D23557: [RISCV 1/10] Recognise riscv32 and riscv64 in triple parsing code
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the llvm-commits mailing list