[PATCH] D23563: [RISCV 6/10] Add basic RISCVAsmParser
Tim Northover via llvm-commits
llvm-commits at lists.llvm.org
Fri Aug 26 14:46:37 PDT 2016
t.p.northover added a comment.
Just spotted one nit on my last pass through the code:
================
Comment at: lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:360-361
@@ +359,4 @@
+ // Parse until end of statement, consuming commas between operands
+ while (getLexer().isNot(AsmToken::EndOfStatement) &&
+ getLexer().is(AsmToken::Comma)) {
+ // Consume comma token
----------------
Isn't the first check redundant here?
https://reviews.llvm.org/D23563
More information about the llvm-commits
mailing list