[PATCH] D23940: Delete dead code

Teresa Johnson via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 26 13:55:24 PDT 2016


On Fri, Aug 26, 2016 at 1:51 PM, Rafael EspĂ­ndola
<rafael.espindola at gmail.com> wrote:
> On 26 August 2016 at 16:04, Teresa Johnson <tejohnson at google.com> wrote:
>> tejohnson added a comment.
>>
>> I tend to agree to remove it, since it isn't being used at all yet. But I think some llvm-lto2 tests need to be updated (that's the only way this could get set now). E.g. test/ThinLTO/X86/internalize.ll
>
> Interesting. Would you be OK with llvm-lto2 exiting with an error on
> an unknown resolution? If so I will do that on Monday.

It should already do that - oh, I see now it is printing an error
message but not actually exiting. Yes, that would be good!

Thanks,
Teresa

>
> Cheers,
> Rafael



-- 
Teresa Johnson | Software Engineer | tejohnson at google.com | 408-460-2413


More information about the llvm-commits mailing list